Convert the utils/tty RBI generator to a Tapioca compiler
#16899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dduugg since you offered 👀 on unsticking me! |
|
@issyl0 I pushed a teensy change, lmk if that unblocks you. |
|
Yes, that works (and I understand what I was doing wrong)! Thank you, @dduugg! ⭐ |
- The preferred way of doing RBI generation is via Tapioca. So I am trying to stop being intimidated by it, by learning how it works. - This is very WIP still, currently failing with the following message because the `module` name is missing in the generated RBI file. ``` There are parse errors in the generated RBI files. Errors: sorbet/rbi/dsl/tty.rbi:8: unexpected token tNL (2001) sorbet/rbi/dsl/tty.rbi:64: unexpected token "end" (2001) ```
issyl0
force-pushed
the
tapioca-compiler-for-tty-rbi
branch
from
5c382bb to
67a096f
Compare
|
I finally got back to this (sorry for the delay) and Sorbet now passes. 🎉 |
dduugg
requested changes
Mar 29, 2024
issyl0
force-pushed
the
tapioca-compiler-for-tty-rbi
branch
2 times, most recently
from
828e214 to
81eaeca
Compare
|
Thanks @dduugg! Changes applied since they all made sense, a lot of it was copypasta from the previous version where I was trying to cover all bases that it turns out we didn't need to (like the boolean types, and some methods being dynamic and some not). |
issyl0
force-pushed
the
tapioca-compiler-for-tty-rbi
branch
from
81eaeca to
db39e93
Compare
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?modulename is missing in the generated RBI file.